Conda Packages#6
Open
marcus-o wants to merge 12 commits intophoebe-p:develfrom
Open
Conversation
…linux, can't test)
…ssfft the compile flag for fftw3 in fft_iface.cpp was wrong so fftw3 was never used there is no speed difference b/w kissfft and mkl fftw in my case
Abelarm
pushed a commit
to Abelarm/S4
that referenced
this pull request
Mar 30, 2024
# This is the 1st commit message: try M1 with clang # This is the commit message phoebe-p#2: test removing boost for compiling # This is the commit message phoebe-p#3: is this or one level more? # This is the commit message phoebe-p#4: what? # This is the commit message phoebe-p#5: we are close # This is the commit message phoebe-p#6: is this the correc path? # This is the commit message phoebe-p#7: testing on mac intel # This is the commit message phoebe-p#8: test new file # This is the commit message phoebe-p#9: testing clang instead of gcc # This is the commit message phoebe-p#10: will it work that way? # This is the commit message phoebe-p#11: debug # This is the commit message phoebe-p#12: debug print
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Phoebe,
you seem to maintain the most recent repository of S4.
I created conda packages for python 3.7 of your devel branch with minimal changes. I don't really have experience with making packages, but they seem to work in a clean environment. Performance is a little bit worse than a native compilation, as I did not want to optimize for a certain architecture, however, they should save people the headache of compilation for smaller problems. If somebody wants to verify that they work on their computer or not it would be great!
Best,
Marcus